[generator] fixed new warnings introduced #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#217 When testing generator from xamarin-android/master, I noticed that building a binding project has some *new* warnings: ``` obj/Debug/generated/src/GoogleAnalytics.Tracking.ILogger.cs(159,14): warning CS0109: The member 'ILoggerInvoker.class_ref' does not hide an accessible member. The new keyword is not required. ``` Binding project: https://github.com/jonathanpeppers/GoogleAnalytics/tree/master/GoogleAnalytics.Droid This was due to a change made in dotnet#217, I was *tricked* by how warnings operate differently in `generator-Tests` than what happens in a real Xamarin.Android binding project. The difference is: - `generator-Tests` put everything in one assembly - Real binding projects have `Java.Lang.*` and Android types in a separate assembly This means that some members that are marked `internal` will not need the `new` keyword at all—even though the tests currently *would* need the `new` keyword. The real fix here is to make the tests generate two separate assemblies so that we are more closely reproducing the situation of a Xamarin.Android binding project. Since we are branching for 15-6 soon, it seems better to revert the `new` keyword change in `InterfaceGen`, and set `AllowWarnings=true` where required in `generator-Tests`.. I also included a comment for every test that sets `AllowWarnings=true`, so that it is clear which warning is occurring.
jonpryor
pushed a commit
that referenced
this pull request
Jan 26, 2024
Changes: dotnet/android-tools@4889bf0...ed102fc * dotnet/android-tools@ed102fc: [Xamarin.Android.Tools.Versions] Add JavaSdkVersion (#226) * dotnet/android-tools@b175674: [ci] Only enable CodeQL on Windows build job (#224) * dotnet/android-tools@2a2e64b: [ci] Add API Scan job (#225) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #217
When testing generator from xamarin-android/master, I noticed that
building a binding project has some new warnings:
Binding project: https://github.com/jonathanpeppers/GoogleAnalytics/tree/master/GoogleAnalytics.Droid
This was due to a change made in #217, I was tricked by how warnings
operate differently in
generator-Teststhan what happens in a realXamarin.Android binding project.
The difference is:
generator-Testsput everything in one assemblyJava.Lang.*and Android types in aseparate assembly
This means that some members that are marked
internalwill not needthe
newkeyword at all—even though the tests currently would needthe
newkeyword. The real fix here is to make the tests generate twoseparate assemblies so that we are more closely reproducing the
situation of a Xamarin.Android binding project.
Since we are branching for 15-6 soon, it seems better to revert the
newkeyword change inInterfaceGen, and setAllowWarnings=truewhere required in
generator-Tests..I also included a comment for every test that sets
AllowWarnings=true, so that it is clear which warning is occurring.